Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [Bug?] "diff -B --color" output doesn't show space errors

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:24

Nanako Shiraishi [off-list ref] writes:
I wanted to try this -B option, and wrote a little test program.

While it shows correctly that the file was rewritten, it doesn't
point out various whitespace mistakes in the file anymore.
As you included the trailing blank lines, I assume you are running
'next'.

The code to emit complete rewrite patch hasn't changed much since it was
written, and I do not think it is aware of any whitespace error checking,
let alone the "trailing blank lines", which is pretty new for even the
regular diff codepath.

But a more interesting thing about your test program is that it exposes to
a bug in the new code in next.  Let me cook up a patch to fix that issue
first, and then build probably a few more patches on it to add whitespace
error highlighting to the complete-rewrite codepath.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help