Re: [msysGit] [PATCH 07/17] Fix __stdcall/WINAPI placement and function prototype

Hi,

On Mon, 14 Sep 2009, Johannes Sixt wrote:

On Montag, 14. September 2009, Marius Storm-Olsen wrote:

quoted

WINAPI is a macro which translates into the proper calling convention, so
replace __stdcall with that.

I've already pointed out elsewhere that the documentation of 
_beginthreadex explicitly says that the calling convention of the 
function pointer must be __stdcall. It does not mention WINAPI. 
Therefore, I think that these two changes are not correct:

quoted

-static __stdcall unsigned ticktack(void *dummy)
+static unsigned WINAPI ticktack(void *dummy)

quoted

-static __stdcall unsigned run_thread(void *data)
+static unsigned WINAPI run_thread(void *data)

You should s/WINAPI/__stdcall/.

I don't think that comments by our most proficient MSys guy should be 
disregarded as thee comments were.

Ciao,
Dscho