Re: [PATCH] upload-pack: add a trigger for post-upload-pack hook

Johannes Schindelin [off-list ref] writes:

Hi,

On Tue, 25 Aug 2009, Junio C Hamano wrote:

quoted

If we are allowed to talk about asking for the moon,

How about

 	run_hook(NULL, "post-upload-pack",
         	 create_full_pack ? "clone" : "fetch,
		 "the moon",
                 NULL);

then?

quoted

and if one of the primary reason for this new hook is statistics, it 
would be useful to see the number of bytes given, where the fetch-pack 
came from, and if we are using git-daemon virtual hosting which of our 
domain served the request.

Certainly those are possible add-on patches, but would you require them to 
be in the same commit?

I was merely responding to the "what else would be useful" question posed
by Peff.

Did you get an impression that I was saying "you must add these otherwise
I'll reject the patch"?

I didn't mean to.  I think it is entirely reasonable to queue the patch in
'pu' (after fixing the NULL termination bug), and start cooking without
any of the additional information.

Having said that, this is an external interface, and until we feel
reasonably sure that we are giving enough information to the hook and
we wouldn't need to change the interface, the series must not come near
'master'.

It might make sense to define the external interface to be "information is
given through the standard input of the hook, formatted in YAML, and here
are the initial set of items that may be fed", so that we do not have to
worry about the details too much.