Re: What's cooking in git.git (Aug 2009, #04; Sun, 23)

Nicolas Pitre wrote:

On Sun, 23 Aug 2009, Junio C Hamano wrote:

quoted

* lt/block-sha1 (2009-08-17) 4 commits
  (merged to 'next' on 2009-08-18 at 67a1ce8)
 + remove ARM and Mozilla SHA1 implementations
 + block-sha1: guard gcc extensions with __GNUC__
 + make sure byte swapping is optimal for git
 + block-sha1: make the size member first in the context struct

Finishing touches ;-)  There were a few Solaris portability patches
floated around that I didn't pick up, waiting for them to finalize.

Those would be described better as Solaris _optimization_ patches.  The 
code is already fully portable as it is, except not necessarily optimal 
in some cases.

Nicolas is right, the code compiles and executes correctly on Solaris as-is.

Here is the state of the two unsubmitted optimization patches:

  1) Change things like __i386__ to __i386 since GCC defines both, but
     SUNWspro only defines __i386.

     This works correctly in my testing.  I'm assuming that a test for
     __amd64 is not necessary and expect that __x86_64 is set whenever
     __amd64 is set.

  2) Set __GNUC__ on SUNWspro v5.10 and up.

     This compiles correctly and passes the test suite, but produces
     warnings for __attribute__'s that sun's compiler has not implemented.
     This produces a very noisy compile.

I've wanted to do some performance testing to see whether this actually
produces an _improvement_.  I'll try today.

-brandon