Re: [PATCH] remove ARM and Mozilla SHA1 implementations

On Mon, 24 Aug 2009, Johannes Schindelin wrote:

Hi,

On Mon, 24 Aug 2009, Johannes Schindelin wrote:

quoted

On Mon, 24 Aug 2009, Nicolas Pitre wrote:

quoted

On Tue, 18 Aug 2009, Johannes Schindelin wrote:

quoted

On Mon, 17 Aug 2009, Nicolas Pitre wrote:

quoted

They are both slower than the new BLK_SHA1 implementation, so it is 
pointless to keep them around.

Signed-off-by: Nicolas Pitre <redacted> ---

Someone else would need to make the call for the PPC version.

If I don't forget, I can test tomorrow on 2 different 32-bit PPCs and 
possibly one 64-bit PPC.

Did you forget?  ;-)

Yes.

At long last (XTools took a real long time to install here; it is an old 
PowerPC running MacOSX):

Best of 10 "git rev-list --all" runs on a full Git repository (including 
my own tree):

before 30ae47b4

	1.85 real, 1.52 user, 0.28 sys

after 30ae47b4

	1.86 real, 1.52 user, 0.28 sys

To be frank, the 1.85 looks like an outlier, so I think there is exactly 0 
difference between the two.

Maybe there wasn't any _code_ difference after all.  According to the 
Makefile, only mingw defines NO_OPENSSL (although there might certainly 
be others).

TRy a build with PPC_SHA1=1, and then compare with BLK_SHA1=1.
And best is to time a fsck --full.


Nicolas