Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH] gitweb: pull ref markes pull out of subject <a> tag

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:18

Giuseppe Bilotta [off-list ref] writes:
2009/8/23 Jakub Narebski [off-list ref]:
quoted
For format_subject_html which you are fixing, and which is used by
'shortlog', 'history' and 'tags' views this didn't cause much changes
in layout.  But the way gitweb uses git_print_header_div in views such
as 'tree', 'blob' etc., where the outer (containing) link is made into
*block* element[1] by the way of CSS (display: block) makes layout
(visualisation) very screwed up in older browser.  But I don't expect
you to fix that.

[1] Originally so the area to click is larger.
Fixing that really needs some kind of ridiculously complex
workarounds, or a totally different layout. That is actually one of
the situations where nested links make perfect sense, and it's a real
pity the standard wouldn't allow them, and that some client actually
altered the DOM to 'fix' it. But anyway.
quoted
Signoff?
Aaaargh. Is it enough if I put it here:

Signed-off-by: Giuseppe Bilotta <redacted>
I can manage.

Thanks, both.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help