Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH-v2/RFC 3/6] xutils: fix ignore-all-space on incomplete line

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:18

Nanako Shiraishi [off-list ref] writes:
There are left handed people whose scissors run in the wrong direction.
Heh.
quoted hunk
diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
index b0906ef..38c01e4 100644
--- a/builtin-mailinfo.c
+++ b/builtin-mailinfo.c
@@ -725,7 +725,8 @@ static int scissors(const struct strbuf *line)
 			scissors_dashes_seen |= 02;
 			continue;
 		}
-		if (i + 1 < len && !memcmp(buf + i, ">8", 2)) {
+		if (i + 1 < len &&
+		    !memcmp(buf + i, ">8", 2) || !memcmp(buf + i, "8<", 2)) {
 			scissors_dashes_seen |= 01;
You need a pair of parentheses around the memcmp || memcmp.

I'll squash that in.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help