Re: What's cooking in git.git (Aug 2009, #03; Thu, 20)

Mark A Rada [off-list ref] writes:

Unless I missed a case, the tests show that the extra condition check
that was added in the &git_snapshot routine is never actually executed,
because a disabled snapshot format is not added to @snapshot_fmts, which
is checked first.

snippet:
5178     } elsif (!grep($_ eq $format, @snapshot_fmts)) {
5179         die_error(403, "Unsupported snapshot format");
5180     } elsif ($known_snapshot_formats{$format}{'disabled'}) {
5181         die_error(403, "Snapshot format not allowed");
5182     }
5183

True; filter_snapshot_fmts looks at 'disabled' first.

I do not mind keeping these two lines as belt-and-suspender, though.