Re: [PATCH 0/6 RFC] Series to correct xutils incomplete line handling.

Thell Fowler (git@tbfowler.name) wrote on Aug 19, 2009:

 t/t4015-diff-trailing-whitespace.sh |   95 +++++++++++++++++++++++++++++++++++
 t/t4015-diff-whitespace.sh          |   33 ++++++++++++
 xdiff/xutils.c                      |   20 ++++----
 3 files changed, 138 insertions(+), 10 deletions(-)
 create mode 100755 t/t4015-diff-trailing-whitespace.sh

Don't bother trying this series.  I tried it out on live data today and it 
does not work.  It actually caused regression in the diffs for the 
conversion project I'm working on.

What is _REALLY_ odd is that it didn't make any tests fail in the test 
dir using master, next, and pu.


Perhaps someone can explain what I did wrong when testing?

git checkout master
make -s clean && make -s all && make -s install && cd t && make

I really did do over 9 hours of testing using the test dir.  First with 
just the branches with no modification, then with the modified 
t4015-diff-whitespace.sh, then with the xutils.c patch.  And this was on 
each branch at about 40 minutes per run through.

-- 
Thell