Re: [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile

Hi,

On Sun, 16 Aug 2009, David Aguilar wrote:

On Sun, Aug 16, 2009 at 10:55:29PM +0200, Johannes Schindelin wrote:

quoted

On Sun, 16 Aug 2009, David Aguilar wrote:

quoted

diff --git a/git_remote_cvs/Makefile b/git_remote_cvs/Makefile
index 8dbf3fa..f52c096 100644
--- a/git_remote_cvs/Makefile
+++ b/git_remote_cvs/Makefile

@@ -3,6 +3,15 @@
 #
 pysetupfile:=setup.py
 
+# Setup the DESTDIR for Python.
+ifeq ($(DESTDIR),)
+PYTHON_DESTDIR = /

Hmm.  I think this would break on msysGit.  Not that anybody worked on 
getting Python to compile on msysGit.

(Just to make sure you understand the issue: on msysGit, we set prefix to 
"" (and I think DESTDIR somehow ends up taking on the same value).  Now, 
when DESTDIR is set to "/" and something wants to be copied to 
$(DESTDIR)/something, the latter expands to //something, which tells MSys 
not to expand //something to the correct Windows path.

I see.  Hmm.. setup.py is a real pain.

I'll see if we rework this so that we end up passing "" to
--root instead of /.  I'm going to be gone for a few hours so
probably won't be able to try it out until tonight.

Thinking about it a bit more: you might not need to do anything.   I think 
that msysGit should move to prefix = /mingw anyway.

I hesitated to do that earlier, as all .perl and .sh scripts need MSys.  
But the Git .exe files are MinGW programs, so technically they belong into 
/mingw/bin/ anyway.

But the issue would only really become relevant if anybody supported 
Python on msysGit (and thereby git-remote-cvs, before that, we cannot make 
use of it).

Just a thing to keep in mind.

Ciao,
Dscho