Re: [PATCH 3/4] fast-import: add option command
From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:47:14
Sverre Rabbelier [off-list ref] wrote:
This allows the frontend to specify any of the supported options as long as no non-option command has been given. This way the user does not have to include any frontend-specific options, but instead she can rely on the frontend to tell fast-import what it needs. ---
Missing Signed-off-by.
quoted hunk ↗ jump to hunk
@@ -2460,6 +2465,16 @@ static void parse_one_option(const char *option) } } +static void parse_option(void) +{ + char* option = command_buf.buf + 7;
Git style is "char *option", isn't it?
+
+ if (seen_non_option_command)
+ die("Got option command '%s' after non-option command", option);Indentation is messed up here. 1 tab per level, please. -- Shawn.