[PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak · Jeff Lasslett <hidden> · 2016-06-15
Re: [PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH (resend) 1/3] http.c: free preq when aborting · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH (resend) 2/3] http.c: replace usage of temporary variable for urls · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH (resend) 3/3] Check return value of ftruncate call in http.c · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH (resend) 3/3] Check return value of ftruncate call in http.c · Junio C Hamano <hidden> · 2016-06-15

Re: [PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak

From: Tay Ray Chuan <hidden>
Date: 2016-06-15 22:47:13

Hi,

On Mon, Aug 10, 2009 at 9:42 PM, Jeff Lasslett[off-list ref] wrote:

quoted hunk ↗ jump to hunk

@@ -1216,10 +1220,12 @@ struct http_object_request *new_http_object_request(const char *base_url,

                                CURLOPT_HTTPHEADER, range_header);
       }

+       free(url);
       return freq;

-       free(url);

Freeing after the return didn't make sense. Thanks for spotting this.

On a side note, you could simply do away with the 'url' variable,
since you're going to pass freq->url to curl_setopt.

-- 
Cheers,
Ray Chuan

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help