Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:12

Jeff Lasslett [off-list ref] writes:
In new_http_object_request(), check ftruncate() call return value and
handle possible errors.  Remove possible leak of mem pointed to by url.
Are you assuming that everybody is running libcurl 7.17.0 or later?
Before that version strings given to easy_setopt() were not copied and you
needed to keep them around.

I think freeing url is fine but you would probably need to then give
freq->url to easy_setopt(CURLOPT_URL) if you wanted to do so.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help