Thread (21 messages) flat view 21 messages, 6 authors, 2016-06-15

Re: [PATCH v2] Re: mailinfo: allow individual e-mail files as input

From: Brandon Casey <hidden>
Date: 2016-06-15 22:47:11

Nicolas Sebrecht wrote:
The 06/08/09, Brandon Casey wrote:
quoted
                  I think it's a little strange like that though...

   {
      sed "$1"
   } < "$1"
I'm not sure why this comment. The former

  sed "$1"

whithout anything else is enough.
The "former", or Junio's original patch, effectively has this form:

   {
      sed "$1"
   } < "$1"

Without reading closely enough, I thought it looked like this:

   {
      sed
   } < "$1"

Since I didn't study the sed statement closely enough, I assumed that it was
operating on the remaining portion of the patch email that was redirected to
the block on stdin.  I missed the fact that the file name was supplied to
it.  My comment was that I found it strange (and maybe unintuitive, or maybe
it's just me) that "$1" was piped on stdin and it was supplied as an
argument to sed.

-brandon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help