Re: [PATCH 2/3 v3] Use an external program to implement fetching with curl

Hi,

On Fri, 31 Jul 2009, Daniel Barkalow wrote:

Use the transport native helper mechanism to fetch by http (and ftp, etc).

Signed-off-by: Daniel Barkalow <redacted>
---
Note that the bulk of remote-curl is code moved verbatim from transport.c; 
cleaning it up is a separate topic.

 Makefile      |    5 ++
 remote-curl.c |  139 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 transport.c   |  136 +-------------------------------------------------------
 3 files changed, 145 insertions(+), 135 deletions(-)
 create mode 100644 remote-curl.c

I wanted to suggest using the -C option so that the patch would consist of 
mostly deleted lines (easier to verify then that it was a code move), but 
transport.c is over 1000 lines, so that would not have worked!

So I do like the patch, and you're obviously correct about the clean up.

Ciao,
Dscho