[GITK PATCH] gitk: fix direction of --left-right triangles
From: Thomas Rast <hidden>
Date: 2016-06-15 22:47:08
Subsystem:
the rest · Maintainer:
Linus Torvalds
c961b22 (gitk: Use git log and add support for --left-right, 2007-07-09) introduced --left-right support to gitk, but right from the start, 'gitk --left-right A...B' oriented the triangles the wrong way: commits coming from A had a triangle to the right, and vice versa. To fix this, we simply swap the triangles. (Note that git-log does it right.) Noticed-by: Björn Steinbrink [off-list ref] Signed-off-by: Thomas Rast <redacted> --- Sorry for the double mail, I forgot to Cc the list in the first mail. gitk | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gitk b/gitk
index 4604c83..5be2a76 100755
--- a/gitk
+++ b/gitk@@ -5689,16 +5689,16 @@ proc drawcmittext {id row col} { } elseif {$listed == 3} { # triangle pointing left for left-side commits set t [$canv create polygon \ - [expr {$x - $orad}] $y \ - [expr {$x + $orad - 1}] [expr {$y - $orad}] \ - [expr {$x + $orad - 1}] [expr {$y + $orad - 1}] \ + [expr {$x + $orad - 1}] $y \ + [expr {$x - $orad}] [expr {$y - $orad}] \ + [expr {$x - $orad}] [expr {$y + $orad - 1}] \ -fill $ofill -outline $fgcolor -width 1 -tags circle] } else { # triangle pointing right for right-side commits set t [$canv create polygon \ - [expr {$x + $orad - 1}] $y \ - [expr {$x - $orad}] [expr {$y - $orad}] \ - [expr {$x - $orad}] [expr {$y + $orad - 1}] \ + [expr {$x - $orad}] $y \ + [expr {$x + $orad - 1}] [expr {$y - $orad}] \ + [expr {$x + $orad - 1}] [expr {$y + $orad - 1}] \ -fill $ofill -outline $fgcolor -width 1 -tags circle] } set circleitem($row) $t
--
1.6.4.214.gb5b94