Re: [PATCHv3 1/8] Introduce commit notes

On Wednesday 29 July 2009, Alex Riesen wrote:

On Wed, Jul 29, 2009 at 04:25, Johan Herland[off-list ref] wrote:

quoted

+void get_commit_notes(const struct commit *commit, struct strbuf *sb,
+               const char *output_encoding)
+{
+       static const char *utf8 = "utf-8";

Using an array

  const char utf8[] = "utf-8";

costs you less BSS (no separate storage for the pointer).

Thanks, will be fixed in the next iteration of this topic.

...Johan

-- 
Johan Herland, [off-list ref]
www.herland.net