Re: [PATCH] git svn: add an option to recode pathnames
flat view
From: Eric Wong <hidden>
Date: 2016-06-15 22:47:07
Dmitry Statyvka [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Introduce new option 'svn.pathnameenc' that instructs git svn to recode pathnames to given encoding. It's useful for windows users and for those who works in non-utf8 locales, since otherwise they'll have corrupted file names with non-ascii characters. Signed-off-by: Dmitry Statyvka <redacted> --- git-svn.perl | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)diff --git a/git-svn.perl b/git-svn.perl index ef1d30d..bdd9af0 100755 --- a/git-svn.perl +++ b/git-svn.perl@@ -3343,6 +3343,7 @@ sub new { $self->{absent_dir} = {}; $self->{absent_file} = {}; $self->{gii} = $git_svn->tmp_index_do(sub { Git::IndexInfo->new }); + $self->{pathnameencoding} = Git::config('svn.pathnameenc');
Hi Dmitry, Can we use a more consistent name for the user-visible config option? "svn.pathnameencoding" would be more consistent with the other encoding-related config options we have. I'd also like this option documented in the manpage so more people know about it. Otherwise the patch looks fine though a testcase would be helpful, too. Thanks! -- Eric Wong