Re: [PATCH] git fast-export: add --no-data option

Hi,

On Sat, 25 Jul 2009, Junio C Hamano wrote:

Geoffrey Irving [off-list ref] writes:

quoted

@@ -504,6 +508,8 @@ int cmd_fast_export(int argc, const char **argv,

const char *prefix)
 			     "Import marks from this file"),
 		OPT_BOOLEAN(0, "fake-missing-tagger", &fake_missing_tagger,
 			     "Fake a tagger when tags lack one"),
+		OPT_BOOLEAN(0, "no-data", &no_data,
+			     "Skip output of blob data"),

Shouldn't this be --[no-]data option that defaults to true?  Otherwise you
would accept --no-no-data that looks silly.

Maybe

		OPT_NEGBIT(0, "data", &no_data,
			     "Skip output of blob data", 1),

Hmm?

Ciao,
Dscho