Re: [PATCH 2/3] refactor: use bitsizeof() instead of 8 * sizeof()

On Wed, Jul 22, 2009 at 10:09:56PM -0700, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

On Wed, Jul 22, 2009 at 11:34:34PM +0200, Pierre Habouzit wrote:

quoted

 #define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))
+#define bitsizeof(x)  (CHAR_BIT * sizeof(x))

Isn't our style to use all-caps for macros? I.e., BITSIZEOF?

Perhaps but I'd say similarity between sizeof() and bitsizeof() calls for
consistency in the lowercase in this particular case.

Fair enough. I just wanted to point it out in case nobody thought of it.

-Peff