Re: cvs import and internal plumbing commands

Jeff King [off-list ref] writes:

On Tue, Jul 21, 2009 at 05:43:08PM -0700, Junio C Hamano wrote:

quoted

Note that my suggestion on $PATH=$(git --exec-path):$PATH was a response
to Jeff's message, which was the same message your patch was response to.
In other words, our messages crossed, and I do not have an issue with
fixing this either way.  If your patch fixes the issue correctly that
would be great.

I am still confused about what the "issue" is. That is, why this is a
bugfix for Anthony instead of simply a code modernization. IOW, I think
there is something else broken about his install if cvsimport cannot
find the dashed plumbing commands, and we may simply be papering over
it.

I simply assumed that he was a correct install but for whatever crazy
reason is running /usr/local/libexec/git-core/git-cvsimport directly from
the command line.  That usage won't be helped with the git wrapper at all.

I suspect shell scripted Porcelains like "git-pull" have the same issue,
as we do not seem to have "prepend to PATH" in git-sh-setup.sh at all.
Some like git-gui and instaweb do protect themselves, though.

That being said, I think the code modernization is of value itself, so
let's do it.

Agreed, and thanks.