Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/2] Fix git stash apply

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:05

Johannes Schindelin [off-list ref] writes:
On Tue, 21 Jul 2009, Martin Koegler wrote:
quoted
Signed-off-by: Martin Koegler <redacted>
As "git stash" is run through the Git wrapper, which appends the libexec 
path to PATH, this is no "fix".

Apart from that, it is a nice patch, though, except maybe your leaving 
only white space between the commit subject and the sign-off: you could 
have _said_ that this is converting a dashed command to a non-dashed one, 
instead of sending everybody who is interested enough on a hunt where 
exactly those two lines differ (was not easy to spot, let me tell you 
this).
Thanks for a review.  I think the two patches can be squashed into one and
the subject from the second one reflects what is being done more fairly.
It is modernizing the style of the codebase.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help