Re: found a resource leak in file builtin-fast-export.c
From: Thomas Rast <hidden>
Date: 2016-06-15 22:47:02
Hi Martin Martin Ettl wrote:
I have attached a patch to resolve this.
Please read Documentation/SubmittingPatches in the source tree. And use git to track git.git! As for the actual patch:
quoted hunk ↗ jump to hunk
--- git-1.6.3.3/builtin-fast-export.c 2009-06-22 08:24:25.000000000 +0200 +++ git-1.6.3.3/builtin-fast-export_new.c 2009-07-09 09:44:28.000000000 +0200@@ -442,8 +442,9 @@ static void export_marks(char *file) deco++; } - if (ferror(f) || fclose(f)) + if (ferror(f)) error("Unable to write marks file %s.", file); + fclose(f);
You no longer check the error returned by fclose(). This is important, because the FILE* API may buffer writes, and a write error may only become apparent when fclose() flushes the file.
} static void import_marks(char *input_file)
--
Thomas Rast
trast@{inf,student}.ethz.ch Attachments
- signature.asc [application/pgp-signature] 197 bytes