Re: [PATCH 2/2] Don't clean any untracked submodule's .git dir by default in git-clean

Jason Holden [off-list ref] writes:

If this becomes the final fix, don't forget to update
Documentation/git-clean.txt

That's a note to yourself and other people who are intereseted ;-).

My patch was, as with many other patches I send to this list, no more than
"if you wanted to do that, you would do it like this.".  It definitely
wasn't meant to be the final shape of the resolution of this issue.

This is not my itch with a particularly high priority, and I do not have
infinite amount of time right now to scratch it.

There shouldn't be any output from dir.[ch] recursive removal function
(unless it is reporting an error).  Instead, the caller should say "removed"
only after it actually removed it, and it needs some reorganizing of the
call sequence.

I think the loop in builtin_clean.c should first be refactored into
smaller helper functions before any of these changes happen.  It has got
unmanageably large and ugly over time (or perhaps it was large and ugly
from the beginning. I do not even remember who did it initially).  

Anyway, enjoy your vacation.