Thread (9 messages) flat view 9 messages, 5 authors, 2016-06-15

Re: Troubles when directory is replaced by symlink

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:46:59

Kjetil Barvik schrieb:
Subject: [PATCH] lstat_cache: guard against full match of length of 'name' parameter

longest_path_match() in symlinks.c does exactly what it's name says,
but in some cases that match can be too long, since the
has_*_leading_path() functions assumes that the match will newer be as
long as the name string given to the function.
And these "some cases" are? When "a directory was replaced by a symlink"
("or what??" I am inclined to add). Would you please be very specific
here, perhaps with an example, so that we still know the details in 6 months.
+test_expect_success 'checkout of master - alpha/file and beta/alpha/file should exist' '
test_expect_success 'checkout replaces symlink by directory' '

BTW, this is what the test seems to check, and it is the opposite of what
the mail's Subject says. So, which one is it?
+
+	git checkout master &&
+	ls alpha/file beta/alpha/file
	git checkout master &&
	! test -h alpha &&
	test -f alpha/file &&
	test -f beta/alpha/file

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help