Re: [PATCH 2/2] rebase -i: use some kind of config file to save author information

Hi,

On Tuesday 23 June 2009, Johannes Schindelin wrote:

Hi,

On Tue, 23 Jun 2009, Christian Couder wrote:

quoted

The problem with this is that it will take a lot of time to implement
the features that have been added to rebase -i since the sequencer
stalled, then to polish it, and to get it reviewed and so on, and
during that time other features or changes may be implemented by other
people.

So I prefer to use code from the current sequencer (at
http://repo.or.cz/w/git/sbeyer.git) to start porting step by step
rebase -i to C.

I think that the best way to go forward would be to have something like
fetch--tool, i.e. a builtin helper that successively takes more and more
functionality into C.

Yeah, I started working on something like that.

IMHO a first sensible step would be to implement the commands ("pick",
"squash", "edit") in such a helper, and call them from do_next().

That should take care of the most difficult part, getting the transition
started.

I agree that it looks like a good way forward.

But I had the impression that the sequencer started out almost like this,
but then it also wanted to implement the do_next() and everything.

Yeah, I think at some steps we got something close to that.

Thanks,
Christian.