Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH resend] Test cccmd in t9001-send-email.sh and fix two bugs

From: Markus Heidelberg <hidden>
Date: 2016-06-15 22:46:58

Paolo Bonzini, 17.06.2009:
The first bug is that the --suppress-cc option for `cccmd' was
misspelled as `ccmd' in the code.
quoted hunk ↗ jump to hunk
+++ b/git-send-email.perl
@@ -334,7 +334,7 @@ if (@suppress_cc) {
 }
 
 if ($suppress_cc{'all'}) {
-	foreach my $entry (qw (ccmd cc author self sob body bodycc)) {
+	foreach my $entry (qw (cccmd cc author self sob body bodyccc)) {
Additionally you incorrectly changed bodycc to bodyccc.

Then I noticed that the documentation mentions ccbody, but the code uses
bodycc.
The author seemed to intend using bodycc, since it is also used in the
tests and the commit message (3531e2703d, send-email: --suppress-cc
improvements, 2009-02-15), but besides the documentation, ccbody is used
in the bash completion.
 		$suppress_cc{$entry} = 1;
 	}
 	delete $suppress_cc{'all'};
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help