Re: [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests

måndag 15 juni 2009 23:36:35 skrev Mark Struberg [off-list ref]:

From 72dd9d071ce140f267b8b4effd34d122627135e6 Mon Sep 17 00:00:00 2001
From: Mark Struberg <redacted>
Date: Mon, 15 Jun 2009 08:07:53 +0200
Subject: [PATCH] fixed toString for CommitTimeRevFilter + wrote JUnit tests for after, before and between walks

What is the connection between the toString and the rest of the patch? Should be
separate patches.

You should sign off the patches.

Start the subject with a capital letter.

Technically it seemed ok, but I shouldn't have pushed them, as I did, by mistake when pusing
Shawn's latest patch. The formal errors should have been fixed firsts.

-- robin