Re: [PATCH] builtin-remote: (get_one_entry): use strbuf
From: Michael J Gruber <hidden>
Date: 2016-06-15 22:46:57
Bert Wesarg venit, vidit, dixit 15.06.2009 22:45:
Signed-off-by: Bert Wesarg <redacted> --- On Mon, Jun 15, 2009 at 09:49, Michael J Gruber[off-list ref] wrote:quoted
Jim Meyering venit, vidit, dixit 14.06.2009 21:46:quoted
* builtin-remote.c (get_one_entry): Use xmalloc, not malloc.Learning something new with every patch... Sorry, Junio; thanks, Jim!One more reason to re-use existing string handling functions.
Well, when we discussed this before v2 I asked for guidance about strbuf, esp. regarding the issue of allocating/freeing. From your patch I infer that "strbuf_detach" is what I was looking for. (And yes, it is in the api doc where I overlooked it.)
quoted hunk ↗ jump to hunk
builtin-remote.c | 21 ++++++++++----------- 1 files changed, 10 insertions(+), 11 deletions(-)diff --git a/builtin-remote.c b/builtin-remote.c index 709f8a6..31adeaa 100644 --- a/builtin-remote.c +++ b/builtin-remote.c
For whatever reason, your patch does not apply (am) here on top of next + Jim's patch. Given the context (xmallocs), it looks like it's against something + Jim's patch. OTOH: 709f8a6 show's a get_one_entry with mallocs. Did you hand edit the diff? Michael