Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCHv3 3/4] submodule, repack: migrate to git-sh-setup's say()

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:57

Junio C Hamano [off-list ref] writes:
...
If the convention is "GIT_QUIET, when set to non-empty string, squelches
the output", then I think the callers should be more consistent and the
call to prune-packed should say something like this, which is admittedly a
roundabout way:

	git prune-packed ${GIT_QUIET:+-q}

for consistency (and then what you set to GIT_QUIET in the first hunk I
quoted does not matter anymore---it can even be t or 1 or whatever).

I think this does not matter too much, because I suspect that in the
longer term scripted Porcelains are going away, but still...
What I meant was that my _style_ comment does not matter too much.  The
addition of "quiet" _is_ a worthwhile thing to do, I think.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help