[PATCH] git gui: remove warning when deleting correctly merged remote branch

Subsystems: the rest

STALE3731d

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] git gui: remove warning when deleting correctly merged remote branch

From: Heiko Voigt <hidden>
Date: 2016-06-15 22:46:57

If the user wants to delete a remote branch and selects the correct
"merged into" we should not warn that "Recovering deleted branches is
difficult". For local branches we do the same already.

Signed-off-by: Heiko Voigt <redacted>
---
 git-gui/lib/remote_branch_delete.tcl |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/git-gui/lib/remote_branch_delete.tcl b/git-gui/lib/remote_branch_delete.tcl
index 4e02fc0..31e0947 100644
--- a/git-gui/lib/remote_branch_delete.tcl
+++ b/git-gui/lib/remote_branch_delete.tcl
@@ -208,13 +208,15 @@ method _delete {} {
 		return
 	}
 
-	if {[tk_messageBox \
-		-icon warning \
-		-type yesno \
-		-title [wm title $w] \
-		-parent $w \
-		-message [mc "Recovering deleted branches is difficult.\n\nDelete the selected branches?"]] ne yes} {
-		return
+	if {$checktype ne {head}} {
+		if {[tk_messageBox \
+			-icon warning \
+			-type yesno \
+			-title [wm title $w] \
+			-parent $w \
+			-message [mc "Recovering deleted branches is difficult.\n\nDelete the selected branches?"]] ne yes} {
+			return
+		}
 	}
 
 	destroy $w
-- 
1.6.3.1.169.g33fd


----- End forwarded message -----

Re: [PATCH] git gui: remove warning when deleting correctly merged remote branch

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:47:13

Heiko Voigt [off-list ref] wrote:
If the user wants to delete a remote branch and selects the correct
"merged into" we should not warn that "Recovering deleted branches is
difficult". For local branches we do the same already.

Signed-off-by: Heiko Voigt <redacted>
---
 git-gui/lib/remote_branch_delete.tcl |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
Thanks, applied.
 
-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help