Re: [PATCH] Cast things properly to handle >2G files.

On Sun, 14 Jun 2009, Johannes Schindelin wrote:

Hi,

Disclaimer: if you are offended by constructive criticism, or likely to
answer with insults to the comments I offer, please stop reading this mail
now (and please do not answer my mail, either). :-)

Still with me?  Good.  Nice to meet you.

Just for the record: responding to a patch is my strongest way of saying
that I appreciate your work.

On Sun, 14 Jun 2009, Alfred M. Szmidt wrote:

quoted

This small patch fixes things so that repack, fsck, and other things
work on >2GiB files.  There are still some other problems (cloning
over ssh being one), but this makes it atleast possible to handle such
files.

(not subscribed, please CC)

This is almost perfect, but please add a Signed-off-by: line.

Oh, and maybe add a test like t/t5705-clone-2gb.sh?

Creating test for files >= 2GB is kinda hard.  It'll be really slow and 
take a lot of disk space, and I doubt people will be happy about that.

Been there.  That's the only reason why I created the --index-version 
argument to pack-objects: to fake behavior for huge files by the test 
suite.


Nicolas