Thread (7 messages) flat view 7 messages, 2 authors, 2016-06-15

Re: [JGIT PATCH 1/2] Add getLong to RepositoryConfig

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:46:57

Ferry Huberts [off-list ref] wrote:
Shawn O. Pearce wrote:
quoted
This supports parsing 64 bit configuration values.
...
quoted
+	/**
+	 * Obtain an integer value from the configuration.
s/integer/long/g in this (copy&paste) javadoc part
Its still integer as in from the integer number space, and not say
a floating point decimal.  Thus I didn't bother with this edit,
I figured the method name was clear enough that it would return
a long, but the concept of it parsing only "2g" and not "1.5g"
should go in the documentation.
 
And again, please trim parts you aren't replying to.

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help