Re: What's cooking in git.git (Jun 2009, #01; Fri, 12)

Junio C Hamano wrote:

[Will merge to "master" soon]

* bc/solaris (Sun Jun 7 07:40:29 2009 +0200) 10 commits
 - configure: test whether -lresolv is needed
 + Makefile: insert SANE_TOOL_PATH to PATH before /bin or /usr/bin
 + git-compat-util.h: avoid using c99 flex array feature with Sun
   compiler 5.8
 + Makefile: add section for SunOS 5.7
 + Makefile: introduce SANE_TOOL_PATH for prepending required
   elements to PATH
 + Makefile: define __sun__ on SunOS
 + git-compat-util.h: tweak the way _XOPEN_SOURCE is set on Solaris
 + On Solaris choose the OLD_ICONV iconv() declaration based on the
   UNIX spec
 + Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile
   arguments
 + Makefile: use /usr/ucb/install on SunOS platforms rather than
   ginstall

We saw some success report with Sun's c99 compiler, which would allow us
to include the last remaining patch from Brandon with updates.

No additional updates are necessary.  The report that we saw from Sun's
v5.9 c99 compiler confirmed that it correctly handled the flex array as
used by diff-delta.c/delta.h.  So, we only have to treat compilers older
than v5.9 specially, which is what 203ee91f 'avoid using c99 flex array
feature with Sun compiler 5.8' does.  So I think all of that is ready to
go.

I lost
track of the status of the tip patch for autoconf.  Is it ready to go?
Comments from Solaris folks are appreciated.

I can't test it.  No autotools on these machines.

Ralf said it was all pretty mechanical and with what little autoconf
experience I have, his patch looks like it would do the trick, even
if it would add -lresolv unnecessarily sometimes (i.e. for any Solaris
not requiring NO_IPV6).

-brandon