Re: [PATCH v2 2/6] add a test for git-send-email for threaded mails without chain-reply-to
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:55
Markus Heidelberg [off-list ref] writes:
quoted
What can be done to make the test better?Is this change sufficient? Dumping the stdout into a file and grepping this.
Yup, that is better for test scripts.
quoted hunk
t/t9001-send-email.sh | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index ce26ea4..8f810ab 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh@@ -621,4 +621,15 @@ test_expect_success 'in-reply-to but no threading' ' grep "In-Reply-To: <in-reply-id@example.com>" ' +test_expect_failure 'threading but no chain-reply-to' ' + git send-email \ + --dry-run \ + --from="Example <nobody@example.com>" \ + --to=nobody@example.com \ + --thread \ + --nochain-reply-to \ + $patches $patches >stdout && + grep "In-Reply-To: " stdout +' + test_done-- 1.6.3.2.220.gb421