Thread (9 messages) flat view 9 messages, 1 author, 2016-06-15

Re: [PATCH v2 4/6] add a test for git-send-email for non-threaded mails

From: Markus Heidelberg <hidden>
Date: 2016-06-15 22:46:55
Subsystem: the rest · Maintainer: Linus Torvalds

Signed-off-by: Markus Heidelberg <redacted>
---

Differences to v1:
* dump stdout into a file and grep this
* use "test_must_fail grep" instead of "!git send-email"
  I'm not sure about this. When should test_must_fail be used and when
  is !command OK?

 t/t9001-send-email.sh |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 990dd1a..4a4fa7f 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -621,6 +621,16 @@ test_expect_success 'in-reply-to but no threading' '
 	grep "In-Reply-To: <in-reply-id@example.com>"
 '
 
+test_expect_failure 'no in-reply-to and no threading' '
+	git send-email \
+		--dry-run \
+		--from="Example <nobody@example.com>" \
+		--to=nobody@example.com \
+		--nothread \
+		$patches $patches >stdout &&
+	test_must_fail grep "In-Reply-To: " stdout
+'
+
 test_expect_success 'threading but no chain-reply-to' '
 	git send-email \
 		--dry-run \
-- 
1.6.3.2.220.gb421
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help