[PATCH 19/23] http-push.c::fetch_symref(): use the new http API
From: Tay Ray Chuan <hidden>
Date: 2016-06-15 22:46:54
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH 19/23] http-push.c::fetch_symref(): use the new http API · Tay Ray Chuan <hidden>
- 2016-06-15 · Re: [PATCH 19/23] http-push.c::fetch_symref(): use the new http API · Jakub Narebski <hidden>
- 2016-06-15 · Re: [PATCH 19/23] http-push.c::fetch_symref(): use the new http API · Tay Ray Chuan <hidden>
- 2016-06-15 · Re: [PATCH 19/23] http-push.c::fetch_symref(): use the new http API · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 19/23] http-push.c::fetch_symref(): use the new http API · Tay Ray Chuan <hidden>
From: Mike Hommey <redacted> Signed-off-by: Mike Hommey <redacted> Signed-off-by: Tay Ray Chuan <redacted> --- This is based on Mike's earlier patch: Subject: [WIP Patch 09/12] Use the new http API in fetch_symref() Date: Sun, 18 Jan 2009 09:04:34 +0100 http-push.c | 20 +++----------------- 1 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/http-push.c b/http-push.c
index 455e0aa..1714e4e 100644
--- a/http-push.c
+++ b/http-push.c@@ -2029,27 +2029,13 @@ static void fetch_symref(const char *path, char **symref, unsigned char *sha1) { char *url; struct strbuf buffer = STRBUF_INIT; - struct active_request_slot *slot; - struct slot_results results; url = xmalloc(strlen(repo->url) + strlen(path) + 1); sprintf(url, "%s%s", repo->url, path); - slot = get_active_slot(); - slot->results = &results; - curl_easy_setopt(slot->curl, CURLOPT_FILE, &buffer); - curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer); - curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, NULL); - curl_easy_setopt(slot->curl, CURLOPT_URL, url); - if (start_active_slot(slot)) { - run_active_slot(slot); - if (results.curl_result != CURLE_OK) { - die("Couldn't get %s for remote symref\n%s", - url, curl_errorstr); - } - } else { - die("Unable to start remote symref request"); - } + if (http_get_strbuf(url, &buffer, 0) != HTTP_OK) + die("Couldn't get %s for remote symref\n%s", url, + curl_errorstr); free(url); free(*symref); --
1.6.3.1