Re: [PATCH v2 3/8] diff-delta.c: "delta.h" is not a required include

On Fri, 5 Jun 2009, Brandon Casey wrote:

From: Brandon Casey <redacted>

When compiling diff-delta.c with the SUNWspro C99 compiler, it complains

    "diff-delta.c", line 314: identifier redeclared: create_delta

There is nothing in "delta.h" that is required by diff-delta.c, so don't
include it.

Signed-off-by: Brandon Casey <redacted>

NAK.

This is common practice to include the header file declaring function 
prototypes into the file defining the actual function so to make sure 
the declaration matches with the definition.  Deleting that include is 
actively ignoring a problem instead of fixing the cause of it.


Nicolas