Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] diesys calls die and also reports strerror(errno)

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:54

Jeff King [off-list ref] writes:
Should we be calling malloc here? One of the possible error conditions
is that we're out of memory (though xmalloc itself just uses "die"). I
don't think there is a good reason not to use a reasonably-sized static
buffer, which should increase robustness (report() is already using a
1024-character buffer, so any message would be truncated there anyway).
Yup, and at that point, tacking strerror value while expanding possible %
becomes even easier.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help