Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH 10/11] Fix warnings in nedmalloc when compiling with GCC 4.4.0

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:53

Johannes Schindelin [off-list ref] writes:
quoted
quoted
diff --git a/compat/nedmalloc/nedmalloc.c b/compat/nedmalloc/nedmalloc.c
index a381a7d..60a4093 100644
--- a/compat/nedmalloc/nedmalloc.c
+++ b/compat/nedmalloc/nedmalloc.c
@@ -34,7 +34,7 @@ DEALINGS IN THE SOFTWARE.
 /*#define FULLSANITYCHECKS*/
 
 #include "nedmalloc.h"
-#if defined(WIN32) && !defined(__MINGW32__)
+#if defined(WIN32)
  #include <malloc.h>
 #endif
Can somebody enlighten me what this hunk is about, and how it helps GCC
4.4?
It helps in that malloc.h is included even if we happen to compile the 
stuff as a MinGW program.  Otherwise necessary function declarations are 
missing.
...
Hopefully less so, now.
I wish enough information were in the commit log message from the
beginning.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help