Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH] bash: remove always true if statement from __git_ps1()

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:46:52

SZEDER G??bor [off-list ref] wrote:
The recent commits 8763dbb1 (completion: fix PS1 display during a
merge on detached HEAD, 2009-05-16), ff790b6a (completion: simplify
"current branch" in __git_ps1(), 2009-05-10), and d7107ca6
(completion: fix PS1 display during an AM on detached HEAD,
2009-05-26) ensure that the branch name in __git_ps1() is always set
to something sensible.  Therefore, the condition for checking the
non-empty branch name is always fulfilled, and can be removed.

Signed-off-by: SZEDER G??bor <redacted>
---

The patch is the same, but the commit message is different, because
Junio's d7107ca6 has fixed the issue.

 contrib/completion/git-completion.bash |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
Yay, code reduction is good.  :-)

Trivially-Acked-by: Shawn O. Pearce [off-list ref]

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help