Re: [PATCH v0 3/3] Build in git-rebase.sh

On Mon, May 25, 2009 at 4:47 PM, Johannes Sixt [off-list ref] wrote:

Nguyen Thai Ngoc Duy schrieb:

quoted

On Mon, May 25, 2009 at 4:16 PM, Johannes Sixt [off-list ref] wrote:

quoted

Nguyen Thai Ngoc Duy schrieb:

quoted

Someone with better Windows knowledge than me should explain how this works. Windows'
snprintf() just cuts out the last character in this statement:

snprintf(buf, 8, "--%s", "onto"); // result: '--ont', expected: '--onto'

This doesn't happen for me: neither with Windows's original snprintf nor
with the version from compat/. Are you using the latest msysgit
environment to compile, i.e. gcc 4.4? There was a change regarding
SNPRINTF_SIZE_CORR; perhaps that's the culprit?

It could be. I used git.git's next branch, not msys4git or mingw.git
repositories.

OK. Assuming you are using the latest msysgit compiler, which is gcc 4.4,
then you need the SNPRINTF_SIZE_CORR related patch from 4msysgit.git.

It's cross compiler 4.3. Will try the patch.
-- 
Duy