Re: [TopGit PATCH v2] tg-graph: print dependency graph like git log --graph

On Wed, May 20, 2009 at 12:37, Michael Radziej [off-list ref] wrote:

On Wed, May 20, Bert Wesarg wrote:

quoted

ChangeLog:
 v2:
   * fix rename bug which caused random segfaults in gvpr
   * add --decorate option, to print horizontal line from graph node to patch
     name (like gitk do it for commits with tags or branch decorations)
   * in dfs mode we should maintain the order given by the input
   * make dfs mode the default

Hmm, still doesn't work, but in a different way ;-)

a) graphviz 2.16-3ubuntu2

mir@mir:topgit (bw/tg-graph-v2)> tg graph
gvpr: "/usr/local/share/topgit/graph.gvpr", line 952: gg_nl_ret +=
graph_output_commit_line();<<<
 -- cannot convert node_t to string

Just a note: I have never seen this error on my side.

mir@mir:topgit (bw/tg-graph-v2)> tg summary --graphviz
# GraphViz output; pipe to:
#   | dot -Tpng -o <ouput>
# or
#   | dot -Txlib

digraph G {

       graph [
               rankdir = "TB"
               label="TopGit Layout\n\n\n"
               fontsize = 14
               labelloc=top
               pad = "0.5,0.5"
       ];

       "30154name" -> "master";
       "30154name" -> "master";
       "30154name" -> "master";
}

Yeah, sorry I hand edited the patch to use printf instead of echo -e.

can you edit this line in tg-summary.sh:

printf "\t\"%s\" -> \"%s\";\n" "$$name" "$dep"

and change it to this (i.e. remove one '$' from '$$name'):

printf "\t\"%s\" -> \"%s\";\n" "$name" "$dep"

Bert

Michael