Re: [PATCH] Fix type-punning issues

Hi,

On Mon, 11 May 2009, Dan McGee wrote:

In these two places we are casting part of our unsigned char sha1 array 
into an unsigned int, which violates GCCs strict-aliasing rules (and 
probably other compilers). In addition, we had two hashing functions 
defined in object.c. Keep the one function that is "correct" and adopt 
the other ones to fit.

decorate.c: In function ‘hash_obj’:
decorate.c:11: warning: dereferencing type-punned pointer will break
strict-aliasing rules

FWIW we have the same issue in msysGit, having installed GCC 4.4.0 
recently, but I did not dare to send my "fix".  Yours is much nicer.

Thanks,
Dscho