Re: [PATCH] gitk: use --textconv to generate diff text

Jeff King [off-list ref] writes:

On Mon, May 11, 2009 at 09:18:56AM +0200, Johannes Sixt wrote:

quoted

For the most part gitk's focus is on showing history and changes in
a human readable form. For this reason, it makes sense to generate
the patch text in the diff view using --textconv so that textconv drivers
are used if they are defined.

gitk can also generate patches, but we do not use --textconv because
such patches could not be applied.

Signed-off-by: Johannes Sixt <redacted>

As the original author of the textconv code, I am in favor of this.

I agree; I think textconv is meant for this kind of usage.