On Fri, May 8, 2009 at 10:45 AM, Jeff King [off-list ref] wrote:
On Thu, May 07, 2009 at 01:45:48AM +0300, Felipe Contreras wrote:
quoted
-extern const char *prettify_ref(const struct ref *ref);
+extern const char *prettify_refname(const char *refname);
+#define prettify_ref(ref) prettify_refname((ref)->name)
I think it is an improvement for this function to take just the name,
but I don't see much point in keeping the crufty #define compatibility.
I would just fix up the few callers, as it really is just
s/ref/ref->name/.
Good, I started doing that but I thought it would create a big diff
and perhaps it was best to send some RFC before.
Will do that.
--
Felipe Contreras