Thread (1 message) 1 message, 1 author, 2016-06-15
  • (off-list ancestor, not in this archive)
  • Re: Tests in Cygwin · Junio C Hamano <hidden> · 2016-06-15

Re: Tests in Cygwin

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:43

Johannes Sixt [off-list ref] writes:
You could squash in the patch below, where I chose to concatenate
tokens with '+' because I dislike the extra quoting that is otherwise
necessary at the call site. The downside is that it plays games with
IFS, which you might find too ugly and not worth it. It's your call.

BTW, I didn't dare test this as root on my production system; I'll do
that later today elsewhere.
Heh, thanks.

I think my "how about this" weather-balloon patch with your updates should
be split into a three-patch series:

 (1) t/README update to cover the Prerequisite system; we should have done
     this when we applied the feature;

 (2) Addition of multiple-prerequisite feature (and documentation updates
     to t/README);

 (3) Addition of SANITY prerequisite that uses (2).

I personally do not think "SANITY" is such a good thing to look for (I'd
rather make the test fail saying "do not run me as root"), but that is a
separate issue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help