Re: [PATCH 2/2] Use NullProgressMonitor.INSTANCE and indent for loop

I've been using git send-email --format-patch, which doesn't appear to  
add the signed by line. If I do it as the commit, will it add the  
signed-by when it gets committed, and thus I can use send-email? git  
format-patch just seems to dump a load of files into the directory,  
and (as noted elsewhere) the git-rebase doesn't appear to work for me.

Alex

On 6 May 2009, at 21:48, Shawn O. Pearce wrote:

Alex Blewitt [off-list ref] wrote:

quoted

---
.../src/org/spearce/jgit/lib/PackWriter.java       |   25 +++++++++ 
+---------
1 files changed, 13 insertions(+), 12 deletions(-)

Also, I'd like a Signed-off-by line for your patches.  We follow
Linux kernel tradition and use a Signed-off-by line to mean
you agree to the "Developer's Certificate of Origin 1.1" (see
SUBMITTING_PATCHES in the top level directory, part 5).

For the 2 that you've submitted thus far (this one, and the make
private constructor) you can just reply to the email and drop the
SOB line into the message body.  In the future make sure you add
it in with git commit -s or git format-patch -s prior to sending.

-- 
Shawn.