Re: [PATCH] 64-bit fix for date.c.

Jeff King [off-list ref] writes:

On Mon, May 04, 2009 at 04:26:14PM +0200, Bernd Ahlers wrote:

quoted

Jeff King [Mon, Apr 06, 2009 at 03:06:58PM -0400] wrote:

quoted

On Mon, Apr 06, 2009 at 07:26:37PM +0200, Bernd Ahlers wrote:

quoted

@@ -871,13 +871,15 @@ unsigned long approxidate(const char *date)
 	struct timeval tv;
+	time_t time_sec;

[...]
 	gettimeofday(&tv, NULL);
-	localtime_r(&tv.tv_sec, &tm);
+	time_sec = tv.tv_sec;
+	localtime_r(&time_sec, &tm);

Hmph. According to POSIX, tv_sec _is_ a time_t. But I see on FreeBSD,
also, it is actually a "long". So I think this fix makes sense.

Okay. So what's the next step to get this committed? :)

Looks like Junio missed it the first time around, so re-send it to him,
cc'ing the list. And you can add my

  Acked-by: Jeff King [off-list ref]

Thanks.