Re: [PATCH] gitweb: escape searchtext and parameters for replay

On Wed, 29 Apr 2009, Jakub Narebski wrote:

On Wed, 29 Apr 2009, Olaf Hering wrote:

quoted

Am 29.04.2009 um 14:28 schrieb Jakub Narebski: 

quoted

On Wed, 29 April 2009, Michael J Gruber wrote:

quoted

quoted

It should be s=torvalds%40linux instead of s=torvalds\@linux

If you by hand edit URL changing '\@' to simply '@', does changed
gitweb URL works correctly?

I tried akpm@osdl.org, and @ and . was escaped with a backslash.
Removing both, and using the plain mail address worked.

This problem was fixed in 7e431ef (gitweb: Separate search regexp from 
search text), but this fix is present in git 1.5.2 and later,

I have just checked that current gitweb (1.6.2.rc1.20.g8c5b)
does not have this bug...

and kernel.org gitweb is a fork (adding caching mechanism) of
1.4.5-rc0 (according to info in git.kernel.org HTML source), and
it does not have this fix.

  http://git.kernel.org/?p=git/warthog9/gitweb.git;a=summary

I have CC-ed J.H. on this.

... so J.H., or Lea Wiemann, or whoever manages gitweb on kernel.org
should backport this fix to kernel.org's fork of gitweb sources.

-- 
Jakub Narebski
Poland